Repository navigation
Conversation
helloigig
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
November 6, 2026 10:41
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 4m 03s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ite item Revert the useCompositeRoot change so the shared composite code is untouched. RadioRoot now sets the active composite item marker only when the radio is checked and not disabled, so a disabled checked radio no longer holds the group's tab stop and the composite falls back to the first enabled radio.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6179
When the checked radio in a
RadioGroupis disabled, it held the group's single roving tab stop. WithnativeButton, a disabled<button>leaves the tab order, so the whole group could not be reached with Tab.RadioRootnow marks itself as the active composite item only when it is checked and enabled, similar to howTabsTabavoids highlighting a disabled tab. The composite then uses its existing fallback and puts the tab stop on the first enabled radio. The shared composite code is not changed.Behavior:
readOnlychecked radio: keeps the tab stopdisabled: unchanged, every radio hastabIndex -1Tests include a real Tab-key test with
nativeButton.Note: this reverses the test added in #6022 ("keeps the tab stop on a checked radio that is disabled"). Could a maintainer confirm this is the intended behavior?
Known limitation (also on master): if the checked radio becomes disabled after mount, it keeps the tab stop. Happy to open a follow-up for that.